-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gomod): Now ignoring multi-line replace directive inside go.mod files. #14033
fix(gomod): Now ignoring multi-line replace directive inside go.mod files. #14033
Conversation
im aware that the PR and the commits are made from two different users of mine. |
Can't update branch, did you disabled maintainer access or did you open the PR from an organization? |
@viceice "Allow edits by maintainers" was indeed uncheck for some reason. |
Yes and no. If the fork is in an org, the checkbox isn't available and we maintainer hove no access to the fork branch, so we can't update your branch. As we merge a lot branches a day, your PR would be outdated very often and we need to wait for your update. |
🎉 This PR is included in version 31.71.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
As of now, only inline replace directives are commented out with - "// renovate-comment" before further processing. (lib/manager/gomod/artifacts.ts)
Added the same behavior for the multi-line replace variant.
Context:
Closes #11428
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: