Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): Now ignoring multi-line replace directive inside go.mod files. #14033

Merged

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

Changes:

As of now, only inline replace directives are commented out with - "// renovate-comment" before further processing. (lib/manager/gomod/artifacts.ts)

Added the same behavior for the multi-line replace variant.

Context:

Closes #11428

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/manager/gomod/artifacts.ts Outdated Show resolved Hide resolved
lib/manager/gomod/artifacts.ts Outdated Show resolved Hide resolved
lib/manager/gomod/artifacts.ts Outdated Show resolved Hide resolved
lib/manager/gomod/artifacts.ts Outdated Show resolved Hide resolved
lib/manager/gomod/artifacts.ts Outdated Show resolved Hide resolved
@Gabriel-Ladzaretti
Copy link
Collaborator Author

im aware that the PR and the commits are made from two different users of mine.
hope it wont make any problems, will avoid this in the future.

@viceice
Copy link
Member

viceice commented Feb 8, 2022

Can't update branch, did you disabled maintainer access or did you open the PR from an organization?

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Feb 9, 2022

@viceice "Allow edits by maintainers" was indeed uncheck for some reason.
sorry for that.
please also note that the PR was made from a account related to an org, if that what you meant.

@viceice
Copy link
Member

viceice commented Feb 9, 2022

@viceice "Allow edits by maintainers" was indeed uncheck for some reason.
sorry for that.
please also note that the PR was made from a account related to an org, if that what you meant.

Yes and no. If the fork is in an org, the checkbox isn't available and we maintainer hove no access to the fork branch, so we can't update your branch. As we merge a lot branches a day, your PR would be outdated very often and we need to wait for your update.
😉

@rarkins rarkins changed the title fix(manager/gomod): Now ignoring multi-line replace directive inside go.mod files. fix(gomod): Now ignoring multi-line replace directive inside go.mod files. Feb 9, 2022
@rarkins rarkins enabled auto-merge (squash) February 9, 2022 09:26
@rarkins rarkins merged commit 64460a7 into renovatebot:main Feb 9, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.71.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants