Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): optimize remediation to detect already updated branches #14084

Merged
merged 1 commit into from Feb 8, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 8, 2022

Changes:

Enhances transitive remediation logic to detect when a dependency is already updated via either:

  • A higher than necessary upgraded version, or
  • Removal of the dependency altogether

This should remove some unnecessary retrying of updates each run.

Context:

Performance

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 9a43d32 into main Feb 8, 2022
@rarkins rarkins deleted the feat/npm-remediation-already-updated branch February 8, 2022 08:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.69.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

} else {
logger.debug(
{ anyVersionLocked },
`Found alternative versions of qs`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qs ?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants