-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(datasource/pod): Convert to class #14133
refactor(datasource/pod): Convert to class #14133
Conversation
@@ -72,7 +72,7 @@ api.set('npm', npm); | |||
api.set('nuget', nuget); | |||
api.set('orb', new OrbDatasource()); | |||
api.set('packagist', packagist); | |||
api.set('pod', pod); | |||
api.set(PodDatasource.id, new PodDatasource()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should unify those registrations to always use Datasource.id
or 'id'
, can be done in separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, planned to make this once all conversions are done
} | ||
} catch (err) { | ||
handleError(lookupName, err); | ||
function isDefaultRepo(url: string): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move util function to ./common.ts
or ./utils.ts
in a later PR
🎉 This PR is included in version 31.77.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: