refactor(conan): retrieve raw content directly from GitHub #14195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
approved these changes
Feb 13, 2022
|
@JamieMagee i think we have the same thing somewhere else too. Maybe on GitHub platform code for preset fetching. 🤔 |
|
🎉 This PR is included in version 31.81.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Set the
Acceptheader toapplication/vnd.github.v3.rawto directly retrieve the raw content from GitHub, and avoiding a base64 decoding step on our sideContext:
#14176 (comment)
See the request at https://reqbin.com/c-1k89vvte
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: