Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add support for terraform_version in tfe_workspace blocks #14522

Merged
merged 10 commits into from Mar 14, 2022

Conversation

morremeyer
Copy link
Contributor

Changes

Implements support for the terraform_version parameter in tfe_workspace resources.

Context

This resolves #12251 and enables one more dependency to be updated without the need for a regexManager.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice self-requested a review March 4, 2022 13:32
@rarkins rarkins requested a review from secustor March 7, 2022 05:02
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, for your contribution!

I have some small remarks, but nothing big.

lib/modules/manager/terraform/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/terraform/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/terraform/resources.ts Outdated Show resolved Hide resolved
morremeyer and others added 6 commits March 11, 2022 14:54
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@morremeyer
Copy link
Contributor Author

I set no-version as the skip reason if there is no terraform_version , it could probably also be empty. Do you have an opinion about that?

@secustor secustor self-requested a review March 14, 2022 09:27
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-version seems to fit here well.

LGTM

@rarkins rarkins enabled auto-merge (squash) March 14, 2022 09:37
@rarkins rarkins merged commit 2a00fcb into renovatebot:main Mar 14, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@morremeyer morremeyer deleted the feat/terraform-tfc-workspace branch March 14, 2022 15:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable upgrading of terraform_version for terraform cloud workspaces
4 participants