New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run devcontainer as root #14652
Conversation
Works for me on WSL v2 and Windows 11. Don't have access to codespaces, so can't test there /cc @fgreinacher |
@fgreinacher Can you test again? |
Sure! Same problem with |
So the |
I think we should run as root too. the vscode containers will do so too. > docker run --rm -it mcr.microsoft.com/vscode/devcontainers/javascript-node:16 bash -c 'echo $EUID'
0 That will fix the permission issues |
It's working now with a fresh Codespace! |
With root or the version before? |
With the recent version, root in the Dockerfile |
Does this mean Codespaces will work out of the box? |
Yes. @fgreinacher tested it. |
I thought codespaces was open to everyone now? |
🎉 This PR is included in version 32.6.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
explicitly set container user
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: