fix(manager/npm): use root pnpm constraints for workspaces #14660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipAbed
changed the title
PhilipAbed
requested review from
rarkins and
viceice
and removed request for
rarkins
viceice
requested changes
Mar 14, 2022
|
@viceice am i supposed to do anything with that comment? |
Sure. please make code behaving as suggested in issue. |
|
@viceice i already finished that part, now config.Constraints take priority. i meant if anything else is missing let me know it LGTM |
rarkins
reviewed
Mar 17, 2022
viceice
reviewed
Apr 4, 2022
lib/modules/manager/npm/post-update/__snapshots__/pnpm.spec.ts.snap
Outdated
Show resolved
Hide resolved
viceice
reviewed
Apr 6, 2022
viceice
reviewed
Apr 6, 2022
|
Why do you resolved conversions without change or answer? 🤔 |
|
:D i usually fix the code before i resolve the conversation , did i miss something? |
viceice
reviewed
Apr 7, 2022
rarkins
changed the title
rarkins
reviewed
Apr 7, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Apr 7, 2022
|
🎉 This PR is included in version 32.16.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
in the post-update of
pnpm, we will take the rootpackage.jsonand check if it has constraint.Constraint assignment priority:
Context
Closes #14233
related: #14662
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: