Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(manager): strict null checks #15151

Merged
merged 12 commits into from Apr 17, 2022
Merged

refactor(manager): strict null checks #15151

merged 12 commits into from Apr 17, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 17, 2022 •
edited

Changes

  • made some managers strict null safe

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice marked this pull request as draft April 17, 2022 07:28
@viceice viceice changed the title Refactor/strict null managers refactor(managers): strict null managers Apr 17, 2022
@viceice viceice changed the title refactor(managers): strict null managers refactor(managers): strict null checks Apr 17, 2022
@viceice viceice marked this pull request as ready for review April 17, 2022 09:19
@viceice viceice changed the title refactor(managers): strict null checks refactor(manager): strict null checks Apr 17, 2022
@viceice viceice merged commit da6ba64 into main Apr 17, 2022
@viceice viceice deleted the refactor/strict-null-managers branch April 17, 2022 12:34
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@zharinov zharinov Awaiting requested review from zharinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viceice @renovate-release @rarkins