fix(manager:nuget): use git to read current lockfile

[viceice]

Changes

Read current lockfile from git, so we detect changes when multiple restore commands are run.
Currently the second restore causes a reset of previous run.

Context

• fixes NuGet manager does not consider previously updated lockfiles #15390

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

https://github.com/renovate-reproductions/15390-renovate-nuget-lockfile-reproduction/pull/1/files

[viceice]

@rarkins @JamieMagee This will block lockfiule usage on nuget manager, so please review.

[rarkins]

I'm a bit lost. Could anyone summarize it simply?

[viceice]

I'm a bit lost. Could anyone summarize it simply?

Scenario:

• We have 3 project files, a,b,c and b,c depend on a.
• Renovate updates same dep in all projects
• Renovate runs update artifacts on all projects
  • project a run: reads current lockfile, updates lockfile for all projects, because of detected transitive dep, returns all changed lockfiles
  • project b run: reads changed lockfiles, rund restore for a and b, returns only b lockfile, as a didn't change in this run (this overwrites the previous returned lickfile result)
  • project c run: like b, returns on c lockfile
• renovate drops a lockfile from changes

So for correclty change detection we now read the lockfile from git and compare with current files, so all changes files are returned.

[rarkins]

So when you write:

This will block lockfiule usage on nuget manager, so please review.

Do you mean it's currently blocked, and your PR fixes it? Or this PR blocks something?

[viceice]

So when you write:

This will block lockfiule usage on nuget manager, so please review.

Do you mean it's currently blocked, and your PR fixes it? Or this PR blocks something?

This will block lockfile usage, see #15390

[renovate-release]

🎉 This PR is included in version 32.64.1 🎉

The release is available on:

• GitHub release
• 32.64.1

Your semantic-release bot 📦🚀