Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/dashboard): include list of detected package files #15418

Merged
merged 24 commits into from May 16, 2022

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

Changes

Adds detected dependencies to the dependency dashboard's body.

Context

Closes #5488

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti Gabriel-Ladzaretti changed the title Dep dashboard pck files feat(core/dashboard): include list of detected package files May 3, 2022
@rarkins
Copy link
Collaborator

rarkins commented May 3, 2022

I just realized something - we need to consider what to do about multiple baseBranches - each can have their own dependency list. Even if we don't list all, we need to be clear which it is we detect (e.g. the default branch).

@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as draft May 3, 2022 14:58
@JamieMagee
Copy link
Contributor

Is there a risk of truncation? I think GitHub limits to 65k characters1

Footnotes

  1. https://github.community/t/maximum-length-for-the-comment-body-in-issues-and-pr/148867

@rarkins
Copy link
Collaborator

rarkins commented May 3, 2022

Is there a risk of truncation? I think GitHub limits to 65k characters1

Footnotes

  1. github.community/t/maximum-length-for-the-comment-body-in-issues-and-pr/148867

There is, so that's why we're putting it last - so that if any info goes missing it's the dependency list and not the branch list (which is more important IMO)

 - added support for multi/single base branch repos
 - fix alignment for single base branch repos
 - unit tests coverage
 - revert ensureDashBoard's function signature
@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review May 4, 2022 08:24
@Gabriel-Ladzaretti
Copy link
Collaborator Author

Two repos one renovate run, latest results -

@rarkins
Copy link
Collaborator

rarkins commented May 5, 2022

Maybe reverse the words to "Detected dependencies"?

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented May 5, 2022


Multi base branch repo
https://github.com/ladzaretti/5488-dep-dashboard-dev/issues/10


This issue provides visibility into Renovate updates and their statuses. Learn more

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

Branch main
    dockerfile
      Dockerfile
      • ubuntu@20.04
    poetry
      pyproject.toml
      • six@<=1.3.0
Branch dev
    dockerfile
      Dockerfile
      • ubuntu@20.04
    npm
      package.json
      • cookie-parser@^1.4.5
      • express@~4.17.1
      • express-handlebars@>=5.3.4
      • geoip-lite@1.4.*
      • nodemailer@6.7.0
      • redis@3.1.2-3.4.0
      • dotenv@10.0.0
      • nodemon@2.0.14
    poetry
      pyproject.toml
      • six@<=1.3.0

Single base branch repo
https://github.com/ladzaretti/5488-dep-dashboard-dev-single/issues/3


This issue provides visibility into Renovate updates and their statuses. Learn more

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

dockerfile
    Dockerfile
    • ubuntu@20.04
poetry
    pyproject.toml
    • six@<=1.3.0

lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/dashboard-package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/dashboard-package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/dashboard-package-files.ts Outdated Show resolved Hide resolved
- moved logic to finaliseRepo

- added logs
rarkins
rarkins previously approved these changes May 11, 2022
rarkins
rarkins previously approved these changes May 11, 2022
@rarkins rarkins requested a review from viceice May 16, 2022 05:02
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small issues, otherwise LGTM

lib/workers/repository/dependency-dashboard.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
lib/workers/repository/package-files.ts Outdated Show resolved Hide resolved
@Gabriel-Ladzaretti
Copy link
Collaborator Author

@rarkins rarkins merged commit 224d5e7 into renovatebot:main May 16, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti deleted the dep-dashboard-pck-files branch June 26, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Dashboard include list of detected package files
5 participants