Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maven optional #15544

Closed
piotrwielgolaski-tomtom opened this issue May 11, 2022 · 4 comments · Fixed by #15775
Closed

Support maven optional #15544

piotrwielgolaski-tomtom opened this issue May 11, 2022 · 4 comments · Fixed by #15775
Labels
manager:maven Maven (Java) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@piotrwielgolaski-tomtom
Copy link
Contributor

What would you like Renovate to be able to do?

I would like to disable update of optional dependency
https://www.baeldung.com/maven-optional-dependency
I dont see any way to filter by this

If you have any ideas on how this should be implemented, please tell us here.

Ad support for reading also optional similarly as for scope in
https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/maven/extract.ts#L81
When optional is set and has value true, depType can be set as optional

Is this a feature you are interested in implementing yourself?

Yes

@piotrwielgolaski-tomtom piotrwielgolaski-tomtom added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels May 11, 2022
@rarkins rarkins added manager:maven Maven (Java) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others auto:reproduction A minimal reproduction is necessary to proceed and removed priority-5-triage labels May 11, 2022
@rarkins
Copy link
Collaborator

rarkins commented May 11, 2022

Hi, reproduction isn't optional if you're implementing it yourself

@github-actions
Copy link
Contributor

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@piotrwielgolaski-tomtom
Copy link
Contributor Author

Here is reproducer for this issue https://github.com/piotrwielgolaski-tomtom/renovate-issue-15544

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 32.71.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:maven Maven (Java) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants