New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manager/go): fix replace block regex #15547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs test and regex is bad, see codeql error
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you real run against a test repo with latest changes?
Yes, i ran it on this: https://github.com/StinkyLord/15369-go-get-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very hacky, but i don't have a beter solution. Everyone should prefer to use gomodNoMassage
Head branch was pushed to by a user without write access
e30a946
🎉 This PR is included in version 32.68.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
changed the regex so it would support comment lines inside replace block
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: