Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(droneci): support for multiline string image dependency #15578

Merged
merged 2 commits into from May 17, 2022
Merged

feat(droneci): support for multiline string image dependency #15578

merged 2 commits into from May 17, 2022

Conversation

ns-ggeorgiev
Copy link
Contributor

@ns-ggeorgiev ns-ggeorgiev commented May 13, 2022

Fix for issue #15576

Changes

The droneci manager is modified to properly detect when image is specified on multiple lines. For example:

image: "amd64/node:10.0.0\
        @sha256:36adc17e9cceab32179d3314da9cb9c737ffb11f0de4e688f407ad6d9ca32201"

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • [ x ] No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please reduce debug logging to trace
  • can you demonstrate the .drone.yml full updates on a public repo with the new code? (both regular style as well as the newly supported formats)

@ns-ggeorgiev
Copy link
Contributor Author

@rarkins how I can do that. Even if I create the repo, how I can run the code from the fork on it?

@rarkins rarkins marked this pull request as draft May 14, 2022 04:06
@ns-ggeorgiev ns-ggeorgiev requested a review from rarkins May 14, 2022 05:45
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs demo in real repo, both old and new cases to verify all works/updates

lib/modules/manager/droneci/extract.ts Outdated Show resolved Hide resolved
@ns-ggeorgiev
Copy link
Contributor Author

ns-ggeorgiev commented May 14, 2022

real repo demo links in the description

@ns-ggeorgiev ns-ggeorgiev requested a review from rarkins May 14, 2022 05:58
@ns-ggeorgiev ns-ggeorgiev marked this pull request as ready for review May 14, 2022 15:09
@ns-ggeorgiev
Copy link
Contributor Author

@rarkins any reason to sit on this?

lib/modules/manager/droneci/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/droneci/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/droneci/extract.ts Outdated Show resolved Hide resolved
@ns-ggeorgiev ns-ggeorgiev requested a review from viceice May 16, 2022 19:53
@rarkins rarkins changed the title Add support for multiline string image dependency for droneci feat(droneci): support for multiline string image dependency May 17, 2022
@rarkins rarkins merged commit e590043 into renovatebot:main May 17, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants