New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(droneci): support for multiline string image dependency #15578
feat(droneci): support for multiline string image dependency #15578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please reduce debug logging to trace
- can you demonstrate the
.drone.yml
full updates on a public repo with the new code? (both regular style as well as the newly supported formats)
@rarkins how I can do that. Even if I create the repo, how I can run the code from the fork on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs demo in real repo, both old and new cases to verify all works/updates
real repo demo links in the description |
@rarkins any reason to sit on this? |
🎉 This PR is included in version 32.58.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fix for issue #15576
Changes
The droneci manager is modified to properly detect when image is specified on multiple lines. For example:
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://github.com/ggeorgiev/renovate-test/pull/2/files
https://github.com/ggeorgiev/renovate-test/pull/3/files