feat(bumpVersion): add prerelease semver level #15626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
May 18, 2022
rarkins
approved these changes
May 18, 2022
rarkins
requested changes
May 18, 2022
The bumpVersion feature is driven by the the npm semver dependency which supports the prerelease semver level.
Enabling prerelease bumpVersion can lead to version increments like the following:
```
- <version>1.0.0-1</version>
+ <version>1.0.0-2</version>
<dependencies>
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
- <version>42.3.4</version>
+ <version>42.3.5</version>
</dependency>
</dependencies>
```
More details of the initial discussion for this feature can be found here:
renovatebot#15573
alanrossx2
force-pushed
the
feat/enable-prerelease-bumpVersion-support
branch
from
675d5f3
to
a825e3b
Compare
|
The force push in my fork adds the recommended changes: It also rebases against |
|
please don't force push next time, use merge commit instead. we'll squash the PR so don't worry about history. for e push sometimes need a full new review, as all files are marked as changed, so it'll defer PR merge because of more work. |
rarkins
approved these changes
Jun 22, 2022
|
Lint error: |
|
Thanks for the follow up. Seems the latest content caused the linting errors. Prior to pulling the content, I put in a fix. The linter seems to be passing locally now: |
|
I suspect the test cases will pass too: |
rarkins
approved these changes
Jun 25, 2022
|
🎉 This PR is included in version 32.98.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The bumpVersion feature is driven by the the npm semver dependency which supports the prerelease semver level.
Enabling prerelease bumpVersion can lead to version increments like the following:
More details of the initial discussion for this feature can be found here:
#15573
Context
Only
major,minorandpatchare currently supported bumpVersion semver levels. The npm semver dependency which drives the bump mechanism also supportsprerelease. In my case, this would be a useful feature for managing and distributing multiple maven dependencies between repos.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Note: Some unit tests did not run on my M1 Mac due to
JavaScript heap out of memory. They will be reran anyways with the GitHub action.Repo configuration:
Executing the test:
Resulting PR: