New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dockerfile): add support for escape chars and ARG instructions #15751
Conversation
Co-authored-by: StinkyLord <42116482+PhilipAbed@users.noreply.github.com>
TypeError: lineNumberRangesToReplace.at is not a function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i'm not 100% familiar with docker files and this flow so others should review too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the quality of code, extensiveness of tests, and the fact that existing tests were left as-is, hopefully indicating backwards compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, it's the last set of changes before resorting to tokenizer/parser
🎉 This PR is included in version 32.75.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
This rework of the dockerfile extractor causes image parts in ARG values (referenced in FROM statements) to be assembled to one string value. The code in this PR enables auto updates for images that occur as a whole within an ARG value (example here) or split into multiple ARG values (example here).
FROM \ a as stage1
RegExp
.No existing tests were changed/rewritten, therefore I don't expect any breaking changes.
Known Limitations
depName
replacementsONBUILD ARG name=value
Context
escapeChar
)Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Test repositories: