Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib/util): strict null check for test files #15812

Merged
merged 33 commits into from
Jun 19, 2022
Merged

refactor(lib/util): strict null check for test files #15812

merged 33 commits into from
Jun 19, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 31, 2022 •
edited

Changes

  • Added types for tmp package ( related to strictNull in lib/util folder )
  • Expanded folder lib/util into multiple files to make it easier to implement and track strictNullCheck implementation

Context

  • strictNullChecks

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed May 31, 2022
View reviewed changes
tsconfig.strict.json Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as draft May 31, 2022 16:11
@RahulGautamSingh RahulGautamSingh changed the title refactor: expand lib/util for strictNullCheck implementation refactor(lib/util): strict null check for test files Jun 19, 2022
@RahulGautamSingh RahulGautamSingh dismissed a stale review via 679b718 June 19, 2022 04:37
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review June 19, 2022 06:45
@rarkins rarkins requested a review from zharinov June 19, 2022 06:53
viceice
viceice reviewed Jun 19, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more later

lib/util/exec/types.ts Outdated Show resolved Hide resolved
lib/util/exec/docker/index.ts Outdated Show resolved Hide resolved
lib/util/git/author.ts Outdated Show resolved Hide resolved
lib/util/git/index.spec.ts Outdated Show resolved Hide resolved
lib/util/git/index.spec.ts Outdated Show resolved Hide resolved
lib/util/git/index.ts Outdated Show resolved Hide resolved
viceice
viceice requested changes Jun 19, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests instead of types. the tests are wrong, not the types.

package.json Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/template/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh dismissed a stale review via b273f39 June 19, 2022 12:15
@RahulGautamSingh

This comment was marked as outdated.

Sign in to view
@RahulGautamSingh RahulGautamSingh mentioned this pull request Jun 19, 2022
Merged
@viceice viceice enabled auto-merge (squash) June 19, 2022 21:07
@viceice viceice merged commit 3d31fa3 into renovatebot:main Jun 19, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.91.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@zharinov zharinov Awaiting requested review from zharinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RahulGautamSingh @renovate-release @viceice