Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extractedConstraint field for poetry #15922

Merged
merged 10 commits into from
Jun 13, 2022
Merged

feat: add extractedConstraint field for poetry #15922

merged 10 commits into from
Jun 13, 2022

Conversation

hasanwhitesource
Copy link
Contributor

@hasanwhitesource hasanwhitesource commented Jun 7, 2022 •
edited

Changes

  • Added extractedConstraint field to differentiate from the user's config constraint.
  • The constraint will be overridden by the user's config whenever there is a same extractedConstraint.

Context

Relates: #14662

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@PhilipAbed PhilipAbed self-requested a review June 7, 2022 09:24
@hasanwhitesource hasanwhitesource marked this pull request as ready for review June 8, 2022 14:48
@rarkins rarkins requested review from viceice and removed request for PhilipAbed June 9, 2022 05:03
viceice
viceice reviewed Jun 9, 2022
View reviewed changes
lib/modules/manager/types.ts Show resolved Hide resolved
lib/workers/repository/process/lookup/types.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/lookup/index.ts Outdated Show resolved Hide resolved
@viceice viceice mentioned this pull request Jun 9, 2022
Merged
6 tasks
@rarkins rarkins requested a review from viceice June 12, 2022 14:26
@viceice viceice changed the title refactor: add extractedConstraint field for poetry feat: add extractedConstraint field for poetry Jun 13, 2022
@viceice viceice enabled auto-merge (squash) June 13, 2022 08:37
@viceice viceice merged commit 89facd1 into renovatebot:main Jun 13, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.85.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

MaronHatoum pushed a commit to MaronHatoum/renovate that referenced this pull request Jun 14, 2022
@hasanwhitesource @rarkins
@viceice @MaronHatoum
feat: add extractedConstraint field for poetry (renovatebot#15922)
32e27ec 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@PhilipAbed PhilipAbed PhilipAbed left review comments

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hasanwhitesource @renovate-release @viceice @rarkins @PhilipAbed