-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): enable platformAutomerge feature for GHES>=3.3 #15924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs tests for code coverage
rarkins
requested changes
Jun 7, 2022
rarkins
previously approved these changes
Jun 13, 2022
viceice
requested changes
Jun 13, 2022
viceice
approved these changes
Jun 14, 2022
rarkins
changed the title
feat(platform/github): enable platformAutomerge feature for GHES>=3.3
feat(github): enable platformAutomerge feature for GHES>=3.3
Jun 14, 2022
🎉 This PR is included in version 32.86.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR allows the usage of
platformAutomerge
on GitHub Enterprise Server >=3.3. For this we check if GHES is the right version and query the GraphQL API to check if autoMerge is enabled for a repository.As I touched it anyway, I put a version restriction on
hasIssuesEnabled
as well. According to the GraphQL docs, this is available in 3.3 upwards.Context
Fixes #15921
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Test PR on GitHub Enterprise Server 3.3.8: