Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): enable platformAutomerge feature for GHES>=3.3 #15924

Merged
merged 10 commits into from
Jun 14, 2022

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Jun 7, 2022

Changes

This PR allows the usage of platformAutomerge on GitHub Enterprise Server >=3.3. For this we check if GHES is the right version and query the GraphQL API to check if autoMerge is enabled for a repository.

As I touched it anyway, I put a version restriction on hasIssuesEnabled as well. According to the GraphQL docs, this is available in 3.3 upwards.

Context

Fixes #15921

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test PR on GitHub Enterprise Server 3.3.8:
image

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests for code coverage

@Shegox Shegox marked this pull request as ready for review June 7, 2022 13:41
lib/modules/platform/github/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/github/index.ts Outdated Show resolved Hide resolved
@Shegox Shegox requested a review from rarkins June 13, 2022 11:15
rarkins
rarkins previously approved these changes Jun 13, 2022
@rarkins rarkins requested a review from viceice June 13, 2022 19:31
lib/modules/platform/github/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/github/index.ts Outdated Show resolved Hide resolved
@viceice viceice requested a review from rarkins June 14, 2022 12:40
@rarkins rarkins changed the title feat(platform/github): enable platformAutomerge feature for GHES>=3.3 feat(github): enable platformAutomerge feature for GHES>=3.3 Jun 14, 2022
@rarkins rarkins enabled auto-merge (squash) June 14, 2022 14:44
@rarkins rarkins merged commit 6a78436 into renovatebot:main Jun 14, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.86.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platformAutomerge doesn't work on GHES
4 participants