Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update WorkerExtractConfig type definition #16020

Merged
merged 18 commits into from
Jun 16, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jun 11, 2022

Changes

  • Added required templates to RegExManagerTemplates and CustomManager for type-consistency
  • WorkerExtractConfig now includes fields from ExtractConfig and CustomExtractConfig and some other properties necessary for extract-cache-fingerprint

Context

  • Make extract-cache-fingerprint more robust by eliminating the fields from config which do not contribute to extract logic

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jun 11, 2022

property ---> reason to include

fileMatch ---> used in creating FileList
updateInternalDeps ---> logic- implementation is present in extract-section
includePaths ---> used in creating fileList
ignorePaths ---> used in filtering fileList
regexManagers ---> important for detecting changes to custom-managers-config

lib/config/types.ts Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
lib/workers/repository/extract/index.ts Outdated Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
lib/workers/repository/extract/index.ts Outdated Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer renaming CustomManager interface in this PR

@rarkins WDYT?

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jun 16, 2022

I prefer renaming CustomManager interface in this PR

@rarkins WDYT?

CustomManager can be done in this one without much noise. Other renames can be part of the next one.

@viceice viceice enabled auto-merge (squash) June 16, 2022 16:09
@viceice viceice merged commit abe821a into renovatebot:main Jun 16, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.89.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants