Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add whitespaces around items with multiple allowed values #16085

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented Jun 15, 2022

Changes

genTable expects [string, string][] as input, but for some the value is Array[] which causes this bug, as Array.proto.toStrings joins with ",".

example:
image

Context

Closes #13349

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Jun 15, 2022

image
image

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Jun 15, 2022

overall diff for configuration-options.md (left before,right after)
image

@rarkins rarkins merged commit b7c6126 into renovatebot:main Jun 15, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.87.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gabriel-Ladzaretti Gabriel-Ladzaretti deleted the 13349-Missing_whitespace_around_items branch June 26, 2022 07:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing whitespace around items in allowedValues in documentation pages
3 participants