Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(modules/datasource): fix null-check issues #16153

Merged
merged 15 commits into from
Jun 20, 2022
Merged

refactor(modules/datasource): fix null-check issues #16153

merged 15 commits into from
Jun 20, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jun 20, 2022 •
edited by viceice

Changes

  • Strict null check implementation

Context

viceice
viceice requested changes Jun 20, 2022
View reviewed changes
tsconfig.strict.json Outdated Show resolved Hide resolved
lib/modules/datasource/cdnjs/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/clojure/index.spec.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

lib/modules/datasource/conan/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/dart/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/datasource.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/datasource.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/galaxy-collection/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-releases/common.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-tags/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-tags/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-tags/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/go/releases-goproxy.spec.ts Outdated Show resolved Hide resolved
@viceice viceice merged commit 93dd940 into renovatebot:main Jun 20, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.91.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RahulGautamSingh @renovate-release @viceice