Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/regex): depName requirement if using the recursive strategy #16225

Merged
merged 15 commits into from Jul 19, 2022
Merged

fix(manager/regex): depName requirement if using the recursive strategy #16225

merged 15 commits into from Jul 19, 2022

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Jun 24, 2022 •
edited by viceice

Changes

Workthrough all matchStrings and then create the dependency.
To keep the current behaviour dependencies are filtered if they have no depName or currentValue after the template fields are processed.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/secustor/renovate-16213

@secustor secustor requested review from viceice and rarkins June 24, 2022 17:49
viceice
viceice reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still having issues with android app review 😕

lib/modules/manager/regex/strategies.ts Show resolved Hide resolved
@secustor secustor requested a review from viceice July 4, 2022 09:04
@secustor secustor dismissed a stale review via f82c138 July 6, 2022 09:04
@secustor secustor requested a review from viceice July 11, 2022 07:38
@HonkingGoose HonkingGoose mentioned this pull request Jul 14, 2022
Merged
6 tasks
@secustor secustor requested a review from viceice July 14, 2022 16:25
viceice
viceice reviewed Jul 14, 2022
View reviewed changes
lib/modules/manager/regex/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/regex/strategies.ts Outdated Show resolved Hide resolved
lib/modules/manager/regex/strategies.ts Outdated Show resolved Hide resolved
lib/modules/manager/regex/utils.ts Outdated Show resolved Hide resolved
secustor and others added 2 commits July 17, 2022 14:32
@secustor @viceice
Update lib/modules/manager/regex/utils.ts
713b1f1 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@secustor
chore: prettier
7f1cf05
@secustor secustor dismissed a stale review via 7f1cf05 July 17, 2022 13:42
@rarkins rarkins requested a review from viceice July 19, 2022 09:31
@viceice viceice enabled auto-merge (squash) July 19, 2022 11:51
@viceice viceice merged commit d0926c3 into renovatebot:main Jul 19, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.119.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
@secustor secustor deleted the fix_regex_issue branch December 4, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose left review comments

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex manager requires depName group when using recursive matching strategy
4 participants
@secustor @renovate-release @viceice @HonkingGoose