Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stabilityDays): suppress branch/PR creation with internalChecksFilter="strict" #16240

Merged
merged 1 commit into from
Jun 26, 2022
Merged

docs(stabilityDays): suppress branch/PR creation with internalChecksFilter="strict" #16240

merged 1 commit into from
Jun 26, 2022

Conversation

maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Jun 25, 2022

Changes

Document suppressing branch/PR creation with internalChecksFilter="strict" instead of prCreation="not-pending"

Context

I have had more success by combining stabilityDays with internalChecksFilter="strict".
If I recall correctly, with prCreation="not-pending", updates get stuck probably because Renovate waits for CI checks which often do not run on branches/pushes, but on PRs only. prCreation can be left immediate.

As an example, the Renovate repo itself uses this combination.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit bdc7655 into renovatebot:main Jun 26, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.99.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maxbrunet maxbrunet deleted the docs/stabilityDays-internalChecksFilter branch July 20, 2022 18:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants