Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fs): Rename getSubDirectory to getParentDir #16446

Merged
merged 7 commits into from Jul 7, 2022

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 6, 2022

Changes

  • Rename getSubDirectory to getParentDir
  • Add tests

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from viceice and rarkins July 6, 2022 14:55
rarkins
rarkins previously approved these changes Jul 6, 2022
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/fs/index.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/zod.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice July 7, 2022 05:18
@viceice viceice enabled auto-merge (squash) July 7, 2022 05:30
@viceice viceice merged commit 83f67c2 into renovatebot:main Jul 7, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.106.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants