Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add repoCache-check before cloning #16533

Merged
merged 22 commits into from Jul 15, 2022
Merged

fix: add repoCache-check before cloning #16533

merged 22 commits into from Jul 15, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • use isModified value from repoCache after validation
  • set isModified value in repoCache for future use

Context

  • improve performance by reducing cases of avoidable cloning

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 11, 2022 22:35
@RahulGautamSingh RahulGautamSingh requested review from viceice, rarkins and zharinov and removed request for viceice and rarkins July 12, 2022 01:26
zharinov
zharinov suggested changes Jul 12, 2022
View reviewed changes
lib/util/git/index.spec.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 13, 2022 04:24
zharinov
zharinov suggested changes Jul 13, 2022
View reviewed changes
lib/util/git/index.spec.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @zharinov
Update lib/util/git/index.spec.ts
d87641a 
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
zharinov
zharinov previously approved these changes Jul 13, 2022
View reviewed changes
zharinov
zharinov previously approved these changes Jul 13, 2022
View reviewed changes
viceice
viceice reviewed Jul 13, 2022
View reviewed changes
lib/util/git/index.ts Outdated Show resolved Hide resolved
lib/util/git/modified-cache.ts Show resolved Hide resolved
@RahulGautamSingh @viceice
Update lib/util/git/index.ts
b11886d 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh @viceice
Update lib/util/git/modified-cache.ts
65cec8a 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins enabled auto-merge (squash) July 15, 2022 05:06
@rarkins rarkins merged commit f506580 into renovatebot:main Jul 15, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.116.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@zharinov zharinov zharinov left review comments

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RahulGautamSingh @renovate-release @zharinov @viceice @rarkins