Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename isBranchStale -> isBranchBehindBase #16577

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • rename isBranchStale -> isBehindBaseBranch

Context

  • we use the term "stale" but that's too vague, what we mean by stale is "behind base branch"

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh changed the title reafctor: rename isBranchStale -> isBehindBaseBranch refactor: rename isBranchStale -> isBehindBaseBranch Jul 14, 2022
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe isBranchBehindBase to align with the other functions?

@RahulGautamSingh
Copy link
Collaborator Author

Maybe isBranchBehindBase to align with the other functions?

Yes makes sense

@RahulGautamSingh RahulGautamSingh changed the title refactor: rename isBranchStale -> isBehindBaseBranch refactor: rename isBranchStale -> isBranchBehindBase Jul 14, 2022
@viceice viceice enabled auto-merge (squash) July 15, 2022 09:08
@viceice viceice merged commit c750725 into renovatebot:main Jul 15, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.117.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants