Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buildpack): enable cache #16591

Merged
merged 8 commits into from Jul 21, 2022
Merged

feat(buildpack): enable cache #16591

merged 8 commits into from Jul 21, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 15, 2022

Changes

Enable buildpack binary caching to <cacheDir>/buildpack. This will speedup worker when processing multiple repos with same tool versions or even same repo with multiple artifact runs.

Context

This is a preparation to only use the sidecar image for docker binary source.
With PR below it will speedup even more.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from zharinov and rarkins July 15, 2022 06:50
@viceice
Copy link
Member Author

viceice commented Jul 15, 2022

should we also pass BUILDPACK_MAX_ALLOCATED_DISK=50 so cach only uses maximal 50% of cache disk space?

lib/util/exec/index.spec.ts Show resolved Hide resolved
@zharinov zharinov self-requested a review July 15, 2022 08:12
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved previously, but actually I was asking for changes

@zharinov zharinov self-requested a review July 15, 2022 11:41
zharinov
zharinov previously approved these changes Jul 15, 2022
@viceice viceice requested a review from rarkins July 19, 2022 06:24
@viceice
Copy link
Member Author

viceice commented Jul 21, 2022

rarkins
rarkins previously approved these changes Jul 21, 2022
rarkins
rarkins previously approved these changes Jul 21, 2022
@viceice viceice enabled auto-merge (squash) July 21, 2022 06:48
@viceice viceice merged commit 4f82df4 into main Jul 21, 2022
@viceice viceice deleted the feat/buildpack-cache branch July 21, 2022 07:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.122.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants