New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use cached configHash to prevent branch updates #16661
feat: use cached configHash to prevent branch updates #16661
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
The fingerprint/hash of an update should be the combination of manager fingerprint plus config hash for that update. Then the fingerprint of a branch is a hash of the list of update hashes. Alternatively you could just use the branch config (which has update configs nested inside) and then combine with the hashes of all managers in the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs test fixes
Updated the tests, they still need some beautification. I will refactor more once the main work is verified.🤞 |
I think we should not use |
The branch cache fingerprint should be updated any time the SHA of the branch changes. |
New changes:
Using stringify method from a new package( |
🎉 This PR is included in version 32.171.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: