-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private gitlab maven repository doesn't work with sbt-package datasource #16761
Comments
Can this problem be reproduced using gitlab.com? It would otherwise be hard for anyone else to fix it if it can only be reproduced privately |
Yes, we can reproduce it with gitlab.com This is the test project https://gitlab.com/sschoebi/renovate-test/ I added you as a maintainer. I use this config:
I start renovate locally and it says:
if I change the renovate code to retry with datasource |
If you think you can fix it yourself then you're welcome to submit a PR. I'm not sure the code you provide is the best way though, ideally we either:
|
@sschoebinger Don't use |
@rarkins is there someone available who is familiar with both the datasources (maven and sbt-package)? For me it would take some time to make a proposal which is not a hack. |
Sorry for that, didn't see your later messages |
@sschoebinger Are you able to test my branch against your repo? (see above PR) |
Yes I tested it. It worked fine for my gitlab.com example 👍 , but not for our self hosted gitlab, I think there is no chance to decide based on a URL if the registry is from "type" gitlab. Is there a reason why we can only fallback to the maven implementation in case of gitlab registries? |
The original reason why we parse In the next iteration, I'll adjust it to support your private package repositories as well. Stay tuned 😉 |
🎉 This issue has been resolved in version 32.137.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us what version of Renovate you run.
32.99.9
Please select which platform you are using if self-hosting.
GitLab self-hosted
If you're self-hosting Renovate, tell us what version of the platform you run.
14.10.5-ee
Was this something which used to work for you, and then stopped?
I never saw this working
Describe the bug
I have a scala library in a private gitlab maven repository. If I use this library in a way that renovate detects it as a maven datasource it will find the right versions und propose a proper update. But if I use this library as a sbt dependency renovate is not able to find any version.
A local setup of renovate and deeper analysis showed that sbt-package datasource parses the html response of the repository in order to find the proper versions whereas maven datasource uses the metadata.xml files.
Unfortunately gitlab maven repository doesn't support directory listings and I'm also not able to classify a dependency found in build.sbt as maven datasource instead of sbt-package.
So I see currently no chance to solve this issue with configuration only.
If I change
lib/modules/datasource
like below it works perfectly fine:So I think all code is already there but no option to choose the maven datasource in case the dependency was found in build.sbt
A very quick fix can be to just retry with datasource
maven
in case we found no dependencies withsbt-package
:I hope someone can help me to get my setup work (scala/sbt with private gitlab maven repository).
Relevant debug logs
No response
Have you created a minimal reproduction repository?
No reproduction repository
The text was updated successfully, but these errors were encountered: