Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dependencyDashboard): split parseDashboardIssue function #16782

Merged
merged 12 commits into from Aug 3, 2022
Merged

refactor(dependencyDashboard): split parseDashboardIssue function #16782

merged 12 commits into from Aug 3, 2022

Conversation

MaronHatoum
Copy link
Contributor

Changes

split and arrangeparseDashboardIssue before adding approve all pending PRs and open all rate limited PR feature

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

MaronHatoum and others added 2 commits July 26, 2022 11:12
@MaronHatoum @nabeelsaabna
Update lib/workers/repository/dependency-dashboard.ts
95dc8c1 
Co-authored-by: Nabeel Saabna <48175656+nabeelsaabna@users.noreply.github.com>
@MaronHatoum @nabeelsaabna
Update lib/workers/repository/dependency-dashboard.ts
c68caa4 
Co-authored-by: Nabeel Saabna <48175656+nabeelsaabna@users.noreply.github.com>
@MaronHatoum MaronHatoum requested a review from viceice July 26, 2022 08:23
nabeelsaabna
nabeelsaabna previously approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@nabeelsaabna nabeelsaabna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaronHatoum @rarkins
Update lib/workers/repository/dependency-dashboard.ts
23af0ed 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
nabeelsaabna
nabeelsaabna previously approved these changes Jul 31, 2022
View reviewed changes
viceice
viceice reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment on open conversation

@rarkins rarkins enabled auto-merge (squash) August 3, 2022 05:13
@rarkins rarkins merged commit 868fa3c into renovatebot:main Aug 3, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.142.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

@nabeelsaabna nabeelsaabna nabeelsaabna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaronHatoum @renovate-release @viceice @rarkins @nabeelsaabna