New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conan): add revisions support #16871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a working public repository to demonstrate this new logic?
@rarkins here is the repository: https://github.com/segretil/renovate-conan-revisions-without-bot |
lib/modules/datasource/conan/__fixtures__/poco_revisions_malformed.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
you still don't understand how renovate handles digests. so please do the following:
this allows renovate to
|
@viceice I pushed what you suggested, and run it on this repository: https://github.com/segretil/-renovate-conan-revisions-get-digest As you can see segretil/-renovate-conan-revisions-get-digest#1 is wrong, this revision does not exist with this version. Do you know why ? |
I implemented what you said but I am still getting this unwanted merge request: segretil/-renovate-conan-revisions-get-digest#6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to remove the current version from packageName, otherwise it will be used wrongly for cache keys
It is now working, it seems like the issue happened because of the cache. Thank you for the suggestion ! |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
maybe we need to update the digest update commitmessage extra, so the pr and commit messages use revisions instead of digest. like we do for docker datasource. |
❤️ thanks for the good work and following all those advices |
🎉 This PR is included in version 32.155.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
This adds basic support for conan revisions using digests. When a package has a revision and is updated, the revision will also get updated.
This:
will become this:
However I did not find how to update the revision when there is no new version. For example, I would like changes that can look like this:
I know it is possible since you update digests in dockerfiles but I did not understand how it worked.
Context
It partially closes #16467
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: