Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass automergeStrategy via platformOptions to createPr #16884

Open
viceice opened this issue Aug 1, 2022 · 3 comments · Fixed by #26448
Open

Pass automergeStrategy via platformOptions to createPr #16884

viceice opened this issue Aug 1, 2022 · 3 comments · Fixed by #26448
Labels
core:automerge Relating to Renovate's automerge capabilities priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented Aug 1, 2022

What would you like Renovate to be able to do?

We should pass automergeStrategy via platformOptions to createPr, so native automerge feature can use the configured merge method.

If you have any ideas on how this should be implemented, please tell us here.

yes, add strategy to PlatformPrOptions interface and pass it here:

export function getPlatformPrOptions(
config: RenovateConfig & PlatformPrOptions
): PlatformPrOptions {
const usePlatformAutomerge = Boolean(
config.automerge &&
(config.automergeType === 'pr' || config.automergeType === 'branch') &&
config.platformAutomerge
);
return {
azureAutoApprove: config.azureAutoApprove,
azureWorkItemId: config.azureWorkItemId,
bbUseDefaultReviewers: config.bbUseDefaultReviewers,
gitLabIgnoreApprovals: config.gitLabIgnoreApprovals,
usePlatformAutomerge,
};
}

Is this a feature you are interested in implementing yourself?

Maybe

@viceice viceice added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready core:automerge Relating to Renovate's automerge capabilities labels Aug 1, 2022
@PhilipAbed
Copy link
Collaborator

can you point us to which task this is related to?
cause seems to me like half a job with the purpose of native automerge feature can use the configured merge method. but not sure where/what how that is happening, any links to other discussions/issues?

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.110.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice
Copy link
Member Author

viceice commented Dec 28, 2023

@joegoldman2 is this really fixed for all platforms?

@rarkins rarkins reopened this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:automerge Relating to Renovate's automerge capabilities priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants