Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate node v14 #16969

Merged
merged 4 commits into from Oct 5, 2022
Merged

feat: deprecate node v14 #16969

merged 4 commits into from Oct 5, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 4, 2022 •
edited

Changes

  • soft node v14 deprecation
  • bump dev container node image

Context

preparation for node v18 bekoming lts in two months

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added breaking Breaking change, requires major version bump v33 labels Aug 4, 2022
rarkins
rarkins reviewed Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V33?

@viceice
Copy link
Member Author

viceice commented Aug 4, 2022

V33?

yes, it's next major, we've another PR pending for it

@rarkins rarkins mentioned this pull request Sep 28, 2022
Closed
8 tasks
@rarkins rarkins changed the base branch from main to v33 October 2, 2022 06:02
@rarkins rarkins marked this pull request as ready for review October 2, 2022 06:03
@viceice viceice requested a review from rarkins October 2, 2022 07:25
HonkingGoose
HonkingGoose reviewed Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found more references to Node 14, maybe those need to be changed/dropped?

package.json Show resolved Hide resolved
.devcontainer/Dockerfile Show resolved Hide resolved
@rarkins rarkins merged commit c6c05f8 into v33 Oct 5, 2022
@rarkins rarkins deleted the feat/deprecate-node-14 branch October 5, 2022 12:03
rarkins added a commit that referenced this pull request Oct 6, 2022
@rarkins
feat: deprecate node v14 (#16969)
a6be7bd 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
rarkins added a commit that referenced this pull request Oct 12, 2022
@rarkins
feat: deprecate node v14 (#16969)
504ab04 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
uhthomas pushed a commit to uhthomas/renovate that referenced this pull request Oct 12, 2022
@rarkins @uhthomas
feat: deprecate node v14 (renovatebot#16969)
b035fda 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
rarkins added a commit that referenced this pull request Oct 13, 2022
@rarkins
feat: deprecate node v14 (#16969)
7ba9600 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
rarkins added a commit that referenced this pull request Oct 19, 2022
@rarkins
feat: deprecate node v14 (#16969)
7c1a658 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
rarkins added a commit that referenced this pull request Oct 21, 2022
@rarkins
feat: deprecate node v14 (#16969)
50b9a21 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
rarkins added a commit that referenced this pull request Oct 23, 2022
@rarkins
feat: deprecate node v14 (#16969)
6fb2cce 
Removes support for Node 14 as a runtime for Renovate.

BREAKING CHANGE: Node 16 is the required runtime for Renovate.
@mkniewallner mkniewallner mentioned this pull request Oct 23, 2022
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose left review comments

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump v33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viceice @rarkins @HonkingGoose