Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/npm): full npm buildpack support #16976

Merged
merged 3 commits into from Aug 5, 2022
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 4, 2022

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins August 5, 2022 07:13
@viceice viceice marked this pull request as ready for review August 5, 2022 07:13
@viceice
Copy link
Member Author

viceice commented Aug 5, 2022

No real run, as we only change the node version selection, which is the same as on yarn. For yarn i did some real runs.

@viceice viceice changed the title feat(manager/npm): support buildpack feat(manager/npm): full npm buildpack support Aug 5, 2022
@viceice viceice requested a review from JamieMagee August 5, 2022 08:28
@viceice viceice mentioned this pull request Aug 5, 2022
6 tasks
@viceice viceice enabled auto-merge (squash) August 5, 2022 15:28
@viceice viceice merged commit be316c5 into main Aug 5, 2022
@viceice viceice deleted the feat/npm-buildpack branch August 5, 2022 16:14
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.150.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants