Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(leiningen): Don't extract deps from commented vectors #16978

Merged
merged 2 commits into from Aug 4, 2022
Merged

fix(leiningen): Don't extract deps from commented vectors #16978

merged 2 commits into from Aug 4, 2022

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Aug 4, 2022 •
edited

Changes

  • Handle common case of dependency commenting in Leiningen

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a preparation for a new parser?

@zharinov
Copy link
Collaborator Author

zharinov commented Aug 4, 2022 •
edited

is this a preparation for a new parser?

Just maintenance

@zharinov zharinov requested a review from viceice August 4, 2022 17:07
viceice
viceice approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you found the issue?

@zharinov
Copy link
Collaborator Author

zharinov commented Aug 4, 2022

Tried to renovate an existing project: https://github.com/zharinov/zprint/pull/3/files

@viceice viceice merged commit 60609dc into renovatebot:main Aug 4, 2022
@viceice viceice deleted the fix/lein-commented-deps branch August 4, 2022 18:13
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.144.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zharinov @renovate-release @viceice