Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): use node versioning for node #17014

Merged
merged 1 commit into from Aug 6, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 6, 2022

Changes

Use node versioning for sidecar node

Context

Closes #17013

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice August 6, 2022 06:16
@viceice viceice enabled auto-merge (squash) August 6, 2022 06:27
@viceice viceice merged commit 53f6878 into main Aug 6, 2022
@viceice viceice deleted the fix/17013-sidecar-node-versioning branch August 6, 2022 06:27
@rarkins
Copy link
Collaborator Author

rarkins commented Aug 6, 2022

DEBUG: Spawning npm install to create ./package-lock.json (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
DEBUG: Updating lock file only (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
DEBUG: No node constraint found - using latest (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
DEBUG: Using docker to execute (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
       "image": "sidecar"
DEBUG: Resolved stable matching version (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
       "toolName": "node",
       "constraint": null,
       "resolvedVersion": "v16.16.0"
DEBUG: Resolved stable matching version (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
       "toolName": "npm",
       "constraint": undefined,
       "resolvedVersion": "8.16.0"
DEBUG: No tag or tagConstraint specified (repository=renovate-tests/npm42, branch=renovate/github-chalk-5.x)
       "image": "docker.io/renovate/sidecar"

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.150.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidecar with node default to non-LTS
3 participants