feat(ruby): improve bump/widen strategy for ~>
#17091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes how Renovate updates Ruby's Gemfile to be more consistent. It includes the following changes:
~>
rangebump
andreplace
strategies, the precision in~>
will never be changed as the implicit upper bound relies on the precision.bump
strategy, it adds or removes the corresponding>=
range to represent the exact lower bound.widen
strategy, it decomposes~>
to>=
and<
ranges.!=
rangebump
strategy, it tries to convert!=
into>=
range.<
,<=
ranges<
and<=
are now consistent with each other.bump
,replace
, andwiden
strategies, it updates these ranges only if the new version violates them.>
,>=
ranges>
and>=
are now consistent with each other.bump
strategy, it always updates the range so that the lower bound sticks with the new version.replace
andwiden
strategies, it updates these ranges only if the new version violates them. (This is supposed to be a rare case)Context
This PR is a second attempt at #11130.
The most important motivation is that Renovate sometimes updates
~>
in a way that the upper bound is unintentionally tightened.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: