fix(manager/gitlabci): clean more than one slash #17132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Aug 11, 2022
viceice
previously requested changes
Aug 11, 2022
|
https://github.com/renovatebot/renovate/blob/main/lib/util/url.ts#L30 should probably remove also multiple leading slashes |
|
@viceice don't think this will work since that only trims 1 slash |
|
Change this in the same pr ? 🤔 |
sure, it's a very small change and probably expected. If it fails too many tests then we should do in seperate PR |
auto-merge was automatically disabled
August 12, 2022 11:23
Head branch was pushed to by a user without write access
rarkins
approved these changes
Aug 14, 2022
|
🎉 This PR is included in version 32.159.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Clear more than one slash from the include block in gitlabci.
Context
According to https://gitlab.com/gitlab-org/gitlab/-/issues/28987#note_392419953 there can be more than one slash.
Currently renovate is giving "Preventing access to file outside the base directory" error.
If we take care of extra slashes we are able to detect the dependencies without and error :
Ran on: https://gitlab.com/hasan.awad/myfirsttestdata
Closes #16600
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: