Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(swissquote): use image captions and lazy-loading #17180

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Aug 15, 2022

Changes

  • Use the new image captions
  • Mark the images for lazy loading
  • Make sure the XKCD link opens in a new tab by using target=_blank

Context

The "flavor text" for the image is now centered below the image. As you can see the HTML to create a image caption is a bit tricky. 馃槃

I'm marking this PR as draft, because we need this PR to be reviewed, and merged first:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose added the status:blocked Issue is blocked by another issue or external requirement label Aug 15, 2022
@HonkingGoose HonkingGoose marked this pull request as ready for review August 16, 2022 09:58
@HonkingGoose HonkingGoose removed the status:blocked Issue is blocked by another issue or external requirement label Aug 16, 2022
@viceice viceice enabled auto-merge (squash) August 19, 2022 18:21
@viceice viceice merged commit e697051 into renovatebot:main Aug 19, 2022
@HonkingGoose HonkingGoose deleted the docs/swissquote-image-captions-lazy-loading branch August 19, 2022 19:41
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 32.167.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants