Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/terraform): remove invalid parts from commitMessageTopic tempate #17271

Merged
merged 2 commits into from Aug 19, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 18, 2022

Changes

that invalid template is currently replaced by emtpy string anyways

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice
Copy link
Member Author

viceice commented Aug 18, 2022

We can use depType as replacement, it would only cause a PR rename.

@viceice
Copy link
Member Author

viceice commented Aug 18, 2022

image

@viceice viceice enabled auto-merge (squash) August 18, 2022 20:50
@viceice viceice disabled auto-merge August 18, 2022 20:51
@viceice viceice changed the title fix(manager/terraform): remove invalid commitMessageTopic tempate fix(manager/terraform): remove invalid parts from commitMessageTopic tempate Aug 18, 2022
@viceice viceice enabled auto-merge (squash) August 18, 2022 20:51
@viceice
Copy link
Member Author

viceice commented Aug 18, 2022

this doesn't harm, as the invalid template was replaced by empty string and multiple spaces are trimmed afterwards

@viceice viceice merged commit 45184dc into main Aug 19, 2022
@viceice viceice deleted the fix/manager/terraform/wrong-default-config branch August 19, 2022 07:08
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 32.165.2 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallowed variable name in default template
3 participants