Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/mint): add mint support #17351

Merged
merged 28 commits into from
Sep 6, 2022

Conversation

coffmark
Copy link
Contributor

@coffmark coffmark commented Aug 23, 2022

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, lib/modules/manager/mint/readme.md
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The following was created pr by renovate
coffmark/renovate-mint-sample#2
coffmark/renovate-mint-sample#3

execution log by renovate
$ node -r ts-node/register/transpile-only -- lib/renovate.ts coffmark/renovate-mint-sample --token=${RENOVATE_TOKEN}
 INFO: Repository started (repository=coffmark/renovate-mint-sample)
       "renovateVersion": "0.0.0-semantic-release"
 INFO: Dependency extraction complete (repository=coffmark/renovate-mint-sample, baseBranch=master)
       "stats": {
         "managers": {"mint": {"fileCount": 1, "depCount": 3}},
         "total": {"fileCount": 1, "depCount": 3}
       }
 INFO: Branch created (repository=coffmark/renovate-mint-sample, branch=renovate/swiftgen-swiftgen-6.x)
       "commitSha": "9d2d1378c963191d4e9d85c8db858874367ecbfc"
 INFO: PR created (repository=coffmark/renovate-mint-sample, branch=renovate/swiftgen-swiftgen-6.x)
       "pr": 2,
       "prTitle": "Update dependency SwiftGen/SwiftGen to v6.6.2"
 INFO: Branch created (repository=coffmark/renovate-mint-sample, branch=renovate/yonaskolb-xcodegen-2.x)
       "commitSha": "231205399e3a4db001896e1c45608059cf7414f5"
 INFO: PR created (repository=coffmark/renovate-mint-sample, branch=renovate/yonaskolb-xcodegen-2.x)
       "pr": 3,
       "prTitle": "Update dependency yonaskolb/xcodegen to v2.32.0"
 INFO: Deleting orphan branch (repository=coffmark/renovate-mint-sample, branch=renovate/configure)
 INFO: Repository finished (repository=coffmark/renovate-mint-sample)
       "durationMs": 12177
✨  Done in 20.62s.

Looking forward to hearing back from you! Thank you!

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2022

CLA assistant check
All committers have signed the CLA.

@coffmark coffmark changed the title Feature/mint support feat: add mint support Aug 23, 2022
@coffmark coffmark changed the title feat: add mint support feat(manager/mint): add mint support Aug 23, 2022
lib/modules/manager/mint/__fixtures__/complex.Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/__fixtures__/simple.Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/__fixtures__/noVersion.Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
coffmark and others added 7 commits August 24, 2022 07:56
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@HonkingGoose
Copy link
Collaborator

Hi @coffmark, did you know that you can "batch" all the suggestions from a PR into a single commit? That is cleaner than making six new commits. 🙈

Read the GitHub Docs about applying suggested changes to learn more. 😉

@coffmark
Copy link
Contributor Author

Hi, @HonkingGoose!
Thank you very much! I didn't know that!

lib/modules/manager/mint/__fixtures__/complex.Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
@coffmark coffmark requested a review from viceice August 27, 2022 02:58
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite complains about not meeting the required coverage.

I also have a question about the docs. 😉

lib/modules/manager/mint/readme.md Show resolved Hide resolved
lib/modules/manager/mint/__fixtures__/noVersion.Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.ts Outdated Show resolved Hide resolved
@coffmark coffmark requested review from viceice and removed request for viceice August 31, 2022 03:05
@coffmark coffmark requested review from HonkingGoose and viceice and removed request for HonkingGoose August 31, 2022 03:05
lib/modules/manager/mint/__fixtures__/Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/readme.md Outdated Show resolved Hide resolved
coffmark and others added 2 commits September 1, 2022 08:16
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
HonkingGoose previously approved these changes Sep 1, 2022
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs. I'll let the maintainers review the code and tests.

lib/modules/manager/mint/__fixtures__/Mintfile Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Show resolved Hide resolved
lib/modules/manager/mint/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Sep 6, 2022
lib/modules/manager/mint/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/mint/extract.spec.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) September 6, 2022 06:08
@viceice viceice merged commit 7dbe0b3 into renovatebot:main Sep 6, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.191.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coffmark coffmark deleted the feature/mint-support branch September 6, 2022 07:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Manager: Mint
6 participants