Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/docker): remove default group commit message topic #17381

Merged
merged 1 commit into from Aug 24, 2022
Merged

fix(datasource/docker): remove default group commit message topic #17381

merged 1 commit into from Aug 24, 2022

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Aug 24, 2022

Changes

remove default group commit message topic configuration to avoid unexpected Docker tags commit suffixes depending on grouping configuration

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same needs to be done for helm datasource, please also do some real test agains a reproduction to verify behavior

@setchy
Copy link
Collaborator Author

setchy commented Aug 24, 2022

I was going to do helm in a different PR @viceice ;)

Testing with a 'real' repository now

@setchy
Copy link
Collaborator Author

setchy commented Aug 24, 2022

@viceice viceice merged commit bcddc69 into renovatebot:main Aug 24, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.174.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
@setchy setchy added type:bug Bug fix of existing functionality datasource:docker labels May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
datasource:docker type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All non-major group now containing Docker tags suffix
3 participants