Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fails to massage pnpm release notes #17466

Merged
merged 10 commits into from
Aug 31, 2022
Merged

fix: fails to massage pnpm release notes #17466

merged 10 commits into from
Aug 31, 2022

Conversation

MaronHatoum
Copy link
Contributor

Changes

added regex to detect if '\n' is missing in release notes

Context

closes #16921

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MaronHatoum MaronHatoum marked this pull request as draft August 29, 2022 11:15
@nabeelsaabna
Copy link
Contributor

can you please add tests

@MaronHatoum MaronHatoum changed the title Bug/fails to massage pnpm release notes fix: fails to massage pnpm release notes Aug 29, 2022
nabeelsaabna
nabeelsaabna previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@nabeelsaabna nabeelsaabna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

viceice
viceice reviewed Aug 29, 2022
View reviewed changes
lib/util/markdown.ts Outdated Show resolved Hide resolved
@MaronHatoum MaronHatoum marked this pull request as ready for review August 30, 2022 07:09
rarkins
rarkins requested changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test you added passes even if the code you added is removed. In other words, it's not testing that your changes work. Test should be one which fails on main but passes for the PR

@rarkins rarkins enabled auto-merge (squash) August 31, 2022 07:28
@rarkins rarkins merged commit 4de1df3 into renovatebot:main Aug 31, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.185.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@Gabriel-Ladzaretti Gabriel-Ladzaretti Awaiting requested review from Gabriel-Ladzaretti

@PhilipAbed PhilipAbed Awaiting requested review from PhilipAbed

@viceice viceice Awaiting requested review from viceice

@nabeelsaabna nabeelsaabna Awaiting requested review from nabeelsaabna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to massage pnpm release notes
5 participants
@MaronHatoum @nabeelsaabna @renovate-release @viceice @rarkins