Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repository/update): stopUpdating not working as expected #17488

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

henrist
Copy link
Contributor

@henrist henrist commented Aug 29, 2022

Changes

Fix stopUpdating logic based on stopUpdatingLabel. It previously incorrectly required the dependency dashboard checkbox to be marked for the stopUpdating logic to behave correctly.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@henrist henrist changed the title fix(repository/update): stop updating label fix(repository/update): stop updating label not working as expected Aug 29, 2022
@henrist henrist changed the title fix(repository/update): stop updating label not working as expected fix(repository/update): stopUpdatingLabel not working as expected Aug 29, 2022
@henrist henrist changed the title fix(repository/update): stopUpdatingLabel not working as expected fix(repository/update): stopUpdating not working as expected Aug 29, 2022
@henrist henrist marked this pull request as ready for review August 29, 2022 21:04
@rarkins rarkins enabled auto-merge (squash) August 30, 2022 04:13
@rarkins rarkins merged commit 04ee279 into renovatebot:main Aug 30, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.183.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@henrist henrist deleted the fix-stop-updating branch August 30, 2022 08:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicted PR gets updated despite the presence of stopUpdatingLabel
3 participants