Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop ppmathis from CODEOWNERS #17566

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Drop invalid codeowner from the file

Context

Only users with write level rights on the repository get pinged by GitHub for review. This means that it won't work as intended for me or @ppmathis, as we don't have write rights. I think the codeowners file should only have users that are actually pinged by GitHub.

How about listing @ppmathis as a "maintainer for features" for Gitea in our About us page instead:

https://docs.renovatebot.com/about-us/#maintainers-for-features

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit f1cbbd1 into renovatebot:main Sep 1, 2022
@HonkingGoose HonkingGoose deleted the patch-1 branch September 1, 2022 10:05
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.187.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants