fix(gomod): explicitly match Gitlab ID for gitlab enterprise servers #17611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Sep 4, 2022
bastianccm
force-pushed
the
match-gitlab-hosttype
branch
from
5a8f2c8
to
e1d2a5c
Compare
viceice
approved these changes
Sep 4, 2022
|
🎉 This PR is included in version 32.190.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change checks for the correct hostType for a given URL to decide if it should try to match it as a Gitlab Enterprise repository for go modules hosted on URLs which do not include "gitlab".
This should fix #17570
Context
TheHostRuleSearchResultdoes not return thehostType. The host-rulesfindmethod will match on hostnames only, if no matchinghostTypeis set.This means, that it is impossible to ask for a hostRule only if it matches thehostType.To be non-breaking, we use this value to match that the hostRule is actually a Gitlab host rule in the gomod datasource, otherwise there is no way of telling a Github Enterprise and Gitlab Enterprise configuration apart.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: