Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasource/conda): support custom registries #17809

Merged
merged 38 commits into from
Oct 5, 2022
Merged

feat(datasource/conda): support custom registries #17809

merged 38 commits into from
Oct 5, 2022

Conversation

titilambert
Copy link
Contributor

@titilambert titilambert commented Sep 15, 2022 •
edited

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@viceice viceice changed the title Make conda datasource support custom registry feat: Make conda datasource support custom registry Sep 15, 2022
@viceice viceice changed the title feat: Make conda datasource support custom registry feat(datasource/conda): support custom registries Sep 15, 2022
viceice
viceice requested changes Sep 15, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test

@titilambert titilambert marked this pull request as draft September 15, 2022 11:03
@titilambert
Copy link
Contributor Author

titilambert commented Sep 16, 2022 •
edited

needs a test

test added

@titilambert titilambert marked this pull request as ready for review September 16, 2022 14:49
viceice
viceice previously requested changes Sep 17, 2022
View reviewed changes
lib/modules/datasource/conda/index.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Sep 22, 2022
View reviewed changes
@rarkins rarkins enabled auto-merge (squash) September 24, 2022 16:00
rarkins
rarkins previously approved these changes Sep 24, 2022
View reviewed changes
viceice
viceice reviewed Sep 24, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed lint and tests

@titilambert
Copy link
Contributor Author

titilambert commented Sep 24, 2022 •
edited

failed lint and tests

Sorry, should be fixed now

@titilambert
Copy link
Contributor Author

@rarkins I just fixed the pipeline issues locally, hopefully it's green now

@titilambert
Copy link
Contributor Author

@rarkins yeah ! I finally got it ! it's green !

rarkins
rarkins previously approved these changes Oct 4, 2022
View reviewed changes
@rarkins rarkins requested a review from viceice October 4, 2022 15:12
viceice
viceice reviewed Oct 4, 2022
View reviewed changes
lib/modules/datasource/conda/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/conda/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/conda/index.ts Outdated Show resolved Hide resolved
@titilambert
Copy link
Contributor Author

@rarkins @viceice It's now ready for, hopefully, the last review :)

rarkins
rarkins previously approved these changes Oct 5, 2022
View reviewed changes
@rarkins rarkins requested a review from viceice October 5, 2022 05:48
viceice
viceice reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/datasource/conda/index.spec.ts Outdated Show resolved Hide resolved
@rarkins rarkins merged commit 699a5cf into renovatebot:main Oct 5, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.218.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@titilambert @CLAassistant @renovate-release @viceice @rarkins