Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): added replacement of react-scripts-ts with react-scripts #17827

Merged
merged 5 commits into from Dec 17, 2022

Conversation

fabb
Copy link
Contributor

@fabb fabb commented Sep 16, 2022

Changes

added replacement of react-scripts-ts with react-scripts

Context

react-scripts-ts is deprecated and hasn't been updated in 4 years because react-scripts supports react since version 2.1.0: https://create-react-app.dev/docs/adding-typescript/

I've added the newest v2 version as replacement version, which is 2.1.8.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

react-scripts-ts is deprecated and hasn't been updated in 4 years because `react-scripts` supports react since version 2.1.0:
https://create-react-app.dev/docs/adding-typescript/

I've added the newest v2 version as replacement version, which is 2.1.8.
rarkins
rarkins previously approved these changes Sep 18, 2022
@rarkins rarkins changed the title added replacement of react-scripts-ts with react-scripts feat(presets): added replacement of react-scripts-ts with react-scripts Sep 18, 2022
@rarkins rarkins enabled auto-merge (squash) September 18, 2022 06:12
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lint fix

@rarkins rarkins requested a review from viceice December 17, 2022 12:22
@rarkins rarkins merged commit 444a221 into renovatebot:main Dec 17, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants