fix: ignoreScripts default #18403
Merged
fix: ignoreScripts default #18403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes ignoreScripts defaulit to be `true`. Closes #18173 BREAKING CHANGE: ignoreScripts now default to true. If allowScripts=true in global config, ignoreScripts must be set to false in repo config if you want all repos to run scripts.
viceice
approved these changes
Oct 19, 2022
rarkins
added a commit
that referenced
this pull request
Oct 21, 2022
Changes ignoreScripts defaulit to be `true`. Closes #18173 BREAKING CHANGE: ignoreScripts now default to true. If allowScripts=true in global config, ignoreScripts must be set to false in repo config if you want all repos to run scripts.
rarkins
added a commit
that referenced
this pull request
Oct 23, 2022
Changes ignoreScripts defaulit to be `true`. Closes #18173 BREAKING CHANGE: ignoreScripts now default to true. If allowScripts=true in global config, ignoreScripts must be set to false in repo config if you want all repos to run scripts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes ignoreScripts defaulit to be
true.Context
Closes #18173
BREAKING CHANGE: ignoreScripts now default to true. If allowScripts=true in global config, ignoreScripts must be set to false in repo config if you want all repos to run scripts.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: