Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/gradle): normalize aliases in versionCatalog #18473

Merged
merged 2 commits into from Oct 23, 2022

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Oct 22, 2022

Changes

Dependency aliases in version catalogs are normalized by Gradle and can then use dot separators only (see here):

When declaring aliases, it’s worth noting that any of the -, _ and . characters can be used as separators, but the generated catalog will have all normalized to .: for example foo-bar as an alias is converted to foo.bar automatically.

This PR adds this normalization to the Gradle manager. This enables aliases with - or _ to be successfully resolved when used as variables. Until now, this only worked for aliases without these characters.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title fix(gradle/manager): normalize aliases in versionCatalog definitions fix(manager/gradle): normalize aliases in versionCatalog Oct 23, 2022
@rarkins rarkins enabled auto-merge (squash) October 23, 2022 05:57
@rarkins rarkins merged commit c02014a into renovatebot:main Oct 23, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 33.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants